Przeglądaj źródła

Fix security bug

Lee Morgan 6 lat temu
rodzic
commit
44a9844870
2 zmienionych plików z 5 dodań i 2 usunięć
  1. 3 1
      views/dashboardPage/account.js
  2. 2 1
      views/shared/validation.js

+ 3 - 1
views/dashboardPage/account.js

@@ -19,12 +19,14 @@ window.accountObj = {
             email: document.querySelector("#accountEmail").value
         }
 
-        if(validator.isSanitary(name)){
+        if(validator.isSanitary(data.name) && validator.isSanitary(data.email)){
             axios.post("/merchant/update", data)
                 .then((response)=>{
                     if(typeof(response.data) === "string"){
                         banner.createError(response.data);
                     }else{
+                        document.querySelector("#title").innerText = data.name;
+
                         merchant.name = data.name;
                         merchant.email = data.email;
 

+ 2 - 1
views/shared/validation.js

@@ -111,10 +111,11 @@ let validator = {
     },
 
     isSanitary: function(str){
-        let disallowed = ["\\", "<", ">", "$"];
+        let disallowed = ["\\", "<", ">", "$", "{", "}", "(", ")"];
 
         for(let char of disallowed){
             if(str.includes(char)){
+                banner.createError("Your string contains illegal characters");
                 return false;
             }
         }